telemetry additions and adjustments #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates telemetry functionality by upgrading the processwatch tool version, refining instruction mix collection, and introducing support for Gaudi and PDU telemetry as hidden features controlled by environment variables.
Key changes:
- Upgrades processwatch from commit hash to version v1.3 and modifies instruction mix telemetry to collect all categories without filtering
- Hides Gaudi telemetry from CLI, enabling it via PERFSPECT_GAUDI_HLSMI_PATH environment variable
- Adds PDU telemetry infrastructure with placeholder implementation, enabled via four environment variables
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Makefile | Updates processwatch version from commit hash to v1.3 |
| internal/script/script_defs.go | Refactors instruction mix script to collect all categories, updates Gaudi script path handling, adds PDU telemetry placeholder |
| internal/report/table_defs.go | Adds PDU telemetry table definition and placeholder rendering function |
| internal/report/render_html.go | Enhances chart rendering to support hidden datasets, refactors instruction mix visualization to sort and hide zero-sum categories |
| cmd/telemetry/telemetry.go | Removes instruction mix filter flag, adjusts frequency defaults, moves Gaudi/PDU telemetry to environment variable control |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…pport hidden dataset flags Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.